[PM-40318] Introduce Web's VaultNextComponet for VFO1 - #22425
Conversation
|
@nick-livefront Tagging you since you've just done similar work in Desktop. I have a few minor things to clean up still, but should be ready for an initial review. |
shane-melton
added
ai-review
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the new Code Review Details
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #22425 +/- ##
==========================================
+ Coverage 53.93% 54.11% +0.18%
==========================================
Files 4297 4312 +15
Lines 136500 137148 +648
Branches 21569 21662 +93
==========================================
+ Hits 73616 74215 +599
- Misses 57518 57533 +15
- Partials 5366 5400 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nick-livefront
left a comment
nick-livefront
left a comment
There was a problem hiding this comment.
Nothing major to me, looks great!
| this.accountService.activeAccount$.pipe( | ||
| getUserId, |
There was a problem hiding this comment.
⛏️ (non-blocking) This is the second usage of activeAccount$ -> getUserId. Should we make a single reference to active account. Minor benefit of one emission rather than two, Angular might optimize that already 🤷
| * Not yet wired: the typed filter adapter that syncs the | ||
| * table's chips to the URL, the redirect that rewrites legacy filter query params, and the | ||
| * `?itemId=&action=` deep link that opens an item on load. Until the chips are wired there is no | ||
| * route to trash or the archive from this page, so both are excluded from the list. |
There was a problem hiding this comment.
FYI: I should have a utility method up for review this morning that handles this.
…ons scoped to the cipher's owning organization
…t attachment storage" This reverts commit 223b78f.
|
@nick-livefront Removed the billing owned change and added support for the new-cipher-menu component instead of re-creating it in VaultNext. |
2 participants
🎟️ Tracking
PM-40318
📔 Objective
Introduce the
VaultNextComponentthat uses the new, sharedVaultItemsTableComponentfor VFO1.Router query parameter mapping and legacy query param handling coming in a followup PR.
📸 Screenshots